-
Notifications
You must be signed in to change notification settings - Fork 129
test-report: istio 1.28-alpha v0.4.0 & v0.5.0 report 9/9 #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @aslakknutsen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aslakknutsen!! this is great
|
||
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension | ||
|
||
#go test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be completed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure.. It's 1 README for potentially many reports, each report would have some kinda difference in the "go test" line so it's not possible to replicate fully. My initial feeling is; it's more of a guide to get you an env you can start running tests. What you want to test is up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you thought about having a Makefile within conformance dir with the different report options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be an option.. hmm
|
||
## Reproduce | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommend to define GIE_VERSION variable and use it when accessing gie crds. it would probably be good to point to a specific version.
|
||
# gie conformance test suite | ||
|
||
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to cd into conformance dir?
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension | |
git clone [email protected]:kubernetes-sigs/gateway-api-inference-extension.git; cd gateway-api-inference-extension/conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe.. depends on the "go test" command. hehe
/ok-to-test |
cf108fd
to
785ae74
Compare
More cowbell? |
@aslakknutsen Shuold we move this to be based on istio master branch? |
@LiorLieberman does it mean Istio now supports GIE in master branch? |
Yes - istio/istio#56845 :) |
23a6c79
to
0c48310
Compare
Basic usage: ``` cd conformance/scripts/istio && \ make setup-env-minikube run-tests readme-update INFERENCE_EXTENSION_VERSION=v0.5.0 ISTIO_VERSION=1.28 ``` Output `conformance/reports/$version/$profile/$project' README and *-report.yaml. Change includes reports for ISTIO_VERSION 1.28-alpha.32ca03082f566513ad9b860f31e7745b0f68dc91 and INFERENCE_EXTENSION_VERSION v0.4.0 and v0.5.0 See conformance/scripts/istio/README for more details.
0c48310
to
f8f2a4c
Compare
/lgtm This is so great! Thank you! @aslakknutsen |
@zetxqx: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @aslakknutsen! /lgtm |
/approve Thanks!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aslakknutsen, kfswain, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Basic usage:
Output `conformance/reports/$version/$profile/$project' README and *-report.yaml.
Change includes reports for ISTIO_VERSION 1.28-alpha.32ca03082f566513ad9b860f31e7745b0f68dc91 and
INFERENCE_EXTENSION_VERSION v0.4.0 and v0.5.0
See conformance/scripts/istio/README for more details.
@LiorLieberman @keithmattix @zetxqx